-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specify an ovn underlay network through MicroOVN #361
feat: specify an ovn underlay network through MicroOVN #361
Conversation
863f7e7
to
27c196b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, hope the refactor wasn't too annoying. I Just have a few nits.
a75a99d
to
aa21322
Compare
27ff7f0
to
fbf7758
Compare
ecba06c
to
48d9bf0
Compare
1a9cf4a
to
867c0e3
Compare
@masnax it seems to solve the issue. But now the interactive combination tests seem to fail at some point. |
@gabrielmougard Needs a rebase. |
e6edc44
to
2d783ee
Compare
25ec1bd
to
1521d31
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
… result Signed-off-by: Gabriel Mougard <[email protected]>
This will be needed to check the API extensions of different services from MicroCloud Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
0402aef
to
dbba372
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
…eed mode Signed-off-by: Gabriel Mougard <[email protected]>
…ve IP is needed Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
dbba372
to
5146a0a
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
5146a0a
to
ecdfb61
Compare
I added the test case @masnax Tell me what you think about it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preseed logic seems to be incorrect, but it's a small fix and since you're going away for a couple weeks, I'll merge this and make a follow-up PR. I'll tag you so you can see how the preseed IPs should be determined.
We also need to update the preseed tests for the new keys, and add the new preseed key to the docs as well.
for peer, system := range c.state { | ||
if len(system.AvailableOVNInterfaces) == 0 { | ||
fmt.Printf("Not enough interfaces available on %s to create an underlay network, skipping\n", peer) | ||
canOVNUnderlay = false | ||
break | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c.state
is not populated for preseed since the recipe is precise, we don't want to change any existing system configurations using a preseed file.
ip, _, err := net.ParseCIDR(underlays[peer]) | ||
if err != nil { | ||
return nil, fmt.Errorf("Failed to parse underlay IP: %w", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input is not a cidr, so this will fail.
closes #239